Skip to content

Vehicle: Remove centi-degrees conversion in MOUNT_CONTROL #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

nexton-winjeel
Copy link
Contributor

Fixes: #11215

@rmackay9
Copy link

rmackay9 commented Mar 8, 2024

Thanks very much for this!

The incorrect use of centi-degrees was fixed in ArduPilot more than 18 months ago. Thanks!

@nexton-winjeel
Copy link
Contributor Author

@rmackay9: Can you confirm what version of ArduPilot this was fixed in?

@DonLakeFlyer: Are you happy with this fix as-is, or do you want to incorporate a version check so that it can use the legacy behaviour for old versions of ArduPilot?

@DonLakeFlyer
Copy link
Contributor

Thanks for the change. It's going to need a version check for back-compat.

@rmackay9
Copy link

rmackay9 commented Mar 8, 2024

Hi @nexton-winjeel,

The ArduPilot fix was released with 4.3.0 which went out on 31-Oct-2022. Since then we've also release 4.4 and we're getting close to releasing 4.5. I still occasionally hear of users back on 4.2 and earlier but not often. Most users are on 4.4 while companies tend to lag a bit but even most of them are on 4.3 or 4.4.

@DonLakeFlyer
Copy link
Contributor

That's pretty far back then. I think it's fine without a version check then.

@DonLakeFlyer DonLakeFlyer merged commit 9a95ec6 into mavlink:master Mar 9, 2024
@rmackay9
Copy link

rmackay9 commented Mar 9, 2024

Thanks so much!

@nexton-winjeel nexton-winjeel deleted the upstream/fix-ap-mount-control branch March 11, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joystick Gimbal Up and Gimbal Down button actions should use degrees (not centi-degrees)
3 participants