core: improve connection error strings, fix threading issue #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
changed the title
This cleans up the messages for connection errors, mostly on Windows. This also fixes a recent regression on Linux leading to thread sanitizer issues.
julianoes
force-pushed
the
pr-connection-error-cleanup
branch
from
9fe4f9b to
5ba151a
Compare
Collaborator
|
Curious now: what was the thread sanitizer issue about? |
Collaborator
Author
|
The previous PR changed the way the return value and errno variables were used, so the logic was broken. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the messages for connection errors, mostly on Windows. This also fixes a recent regression on Linux leading to thread sanitizer issues.
Cleanup after #2662.
Fixes #2675.