Add config limits for portal rooms #469
Conversation
|
This works for portals, but we'd also like to limit for puppeted users. Looking at that now... |
Half-Shot
force-pushed
the
hs/portal-limit
branch
from
7f8e7cf to
6754c3f
Compare
Co-authored-by: Christian Paul <[email protected]>
Co-authored-by: Christian Paul <[email protected]>
Co-authored-by: Christian Paul <[email protected]>
mautrix_telegram/db/portal.py
Outdated
| rows = cls.db.execute(select([func.count()])) | ||
| try: | ||
| count, = next(rows) | ||
| return count | ||
| except StopIteration: | ||
| return 0 |
There was a problem hiding this comment.
Baby's first Python commits (don't commit blindly):
| rows = cls.db.execute(select([func.count()])) | |
| try: | |
| count, = next(rows) | |
| return count | |
| except StopIteration: | |
| return 0 | |
| return cls.db.query(func.count('*')).scalar() |
Please test this. I haven't actually run this.
There was a problem hiding this comment.
No good unfortunately,
AttributeError: 'Engine' object has no attribute 'query'
There was a problem hiding this comment.
The table to count rows in probably needs to be specified somewhere 🤔
There was a problem hiding this comment.
oh derp, I thought that was implied somewhere
mautrix_telegram/db/portal.py
Outdated
| yield from cls._select_all() | ||
|
|
||
| @classmethod | ||
| def get_by_mxid(cls, mxid: RoomID) -> Integer: |
There was a problem hiding this comment.
this seems to have been changed accidentally
|
|
||
| @classmethod | ||
| def count(cls) -> int: | ||
| count = cls.db.execute(select([func.count('*')]).select_from(Table("portal", MetaData()))).scalar() |
There was a problem hiding this comment.
I think this might work
| count = cls.db.execute(select([func.count('*')]).select_from(Table("portal", MetaData()))).scalar() | |
| count = cls.db.execute(cls.t.select([func.count('*')])).scalar() |
|
This needs to count the number of rooms where mxid is not null |
4 participants
Trying to solve #466
I'm not sure if this works, but would value a review to see how close I am.