Skip to content

Allow self-signed SSL #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isbm wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow self-signed SSL #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78aea61
Make httpclient public (replace-able) and add quickfix option for wor…
Jul 22, 2019
ed44404
Fix imports
Jul 22, 2019
2e6fdfa
Fix comments
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions xmlrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package xmlrpc

import (
"bytes"
"crypto/tls"
"encoding/base64"
"encoding/xml"
"errors"
Expand Down Expand Up @@ -359,11 +360,14 @@ func (c *Client) Call(name string, args ...interface{}) (v interface{}, e error)
return call(c.HttpClient, c.url, name, args...)
}

// Global httpClient allows us to pool/reuse connections and not wastefully
// Set this to true if you want to disable SSL verification
var InsecureSkipVerify = false

// Global HttpClient allows us to pool/reuse connections and not wastefully
// re-create transports for each request.
var httpClient = &http.Client{Transport: http.DefaultTransport, Timeout: 10 * time.Second}
var HttpClient = &http.Client{Transport: &http.Transport{TLSClientConfig: &tls.Config{InsecureSkipVerify: InsecureSkipVerify}}, Timeout: 10 * time.Second}

// Call call remote procedures function name with args
func Call(url, name string, args ...interface{}) (v interface{}, e error) {
return call(httpClient, url, name, args...)
return call(HttpClient, url, name, args...)
}