mastodon: add ID.Compare to sort IDs #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds the Compare method to ID in order to make slices of IDs sortable (e.g. via slices.SortFunc(ids, mastodon.ID.Compare)) Signed-off-by: Sebastien Binet <[email protected]>
This CL removes the naive use of fmt.Sprintf in lieu of strconv.FormatInt, which should be slightly more efficient. Signed-off-by: Sebastien Binet <[email protected]>
|
good catch about fmt.Sprint |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 87.51% 77.96% -9.56%
==========================================
Files 15 19 +4
Lines 1354 1652 +298
==========================================
+ Hits 1185 1288 +103
- Misses 125 308 +183
- Partials 44 56 +12 ☔ View full report in Codecov by Sentry. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds the Compare method to ID in order to make slices of IDs
sortable (e.g. via
slices.SortFunc(ids, mastodon.ID.Compare))