MM-65685: fix undefined pollution in myPlaybookRuns #2082
Merged
+44
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindy65
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Thanks @calebroseland - tested with the tar.gz from this PR on a /cloud server and didn't see any ...runs/undefined in the url of HTTP network requests
lindy65
added
QA Review Done
|
/update-branch |
hanzei
approved these changes
Sep 23, 2025
Co-authored-by: Ben Schumacher <[email protected]>
calebroseland
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an error where the
myPlaybookRunsreducer store was polluted with anundefinedentry, which would cause HTTP-Fetch errors while navigating around playbook runs.ReceivedTeamPlaybookRunConnectionsis added somyPlaybookRunsdoesn't hook into it.Ticket Link
https://mattermost.atlassian.net/browse/MM-65685
Checklist
- [ ] Gated by experimental feature flag