Skip to content

feat: support mage in ci/cd pipelines #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support mage in ci/cd pipelines #53

wants to merge 2 commits into from
+26 −0

Conversation

fmartingr
Copy link
Contributor

Summary

This change installs mage in the plugin pipelines adding an input to allow consumers to specify a version.

This was done on an effort to migrate our current make workflows to mage: mattermost/mattermost-plugin-legal-hold#136

@fmartingr fmartingr self-assigned this Mar 24, 2025
@fmartingr fmartingr requested a review from a team as a code owner March 24, 2025 13:38
@fmartingr fmartingr mentioned this pull request Mar 24, 2025
Closed
toninis
toninis suggested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@toninis toninis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to create a completely new reusable workflow for this . Since it's a PoC we do not want to integrate this in our production pipelines .
If it's approved in general as a tool we can discuss

@toninis toninis requested review from spirosoik and jwilander March 24, 2025 14:32
@fmartingr
Copy link
Contributor Author

I would suggest to create a completely new reusable workflow for this . Since it's a PoC we do not want to integrate this in our production pipelines . If it's approved in general as a tool we can discuss

I can work from this branch directly until that happens instead of duplicating the workflows, what do you think?

@fmartingr fmartingr mentioned this pull request Jun 13, 2025
Draft
@hanzei hanzei mentioned this pull request Jun 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saturninoabril saturninoabril Awaiting requested review from saturninoabril saturninoabril was automatically assigned from mattermost/core-build-engineers

@spirosoik spirosoik Awaiting requested review from spirosoik

@jwilander jwilander Awaiting requested review from jwilander

1 more reviewer

@toninis toninis toninis requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@fmartingr fmartingr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmartingr @toninis