feat: Interop roots processing #419

0xVolosnikov · 2025-11-21T18:03:01Z

What ❔

Initial support for the interop roots processing.

Why ❔

Is this a breaking change?

Yes
No

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted.

## What ❔ This PR removes support for EIP-712 transactions, as it's no longer needed.    ## Why ❔    ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist   - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.

## What ❔ Fixes issues reported by Audittens, mostly related to rlp parsing (not rejecting non-canonical encodings)    ## Why ❔    ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist   - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.

0xVolosnikov · 2025-11-21T21:47:39Z

Cargo.toml

 [workspace.dependencies]
-zksync_os_evm_errors = { version = "0.0.10", default-features =  false }
-zksync_os_interface = { version = "0.0.10"}
+zksync_os_evm_errors = { git = "https://github.com/matter-labs/zksync-os-interface", branch = "vv-interop-roots", package = "zksync_os_evm_errors", default-features =  false }


To not forget to update

matter-labs/zksync-os-interface#34

0xVolosnikov · 2025-11-21T21:49:01Z

tests/instances/interop/dummy_interop_root_storage_v30.txt

@@ -0,0 +1 @@
+608060405234801561000f575f5ffd5b506004361061004a575f3560e01c80633b43dbde1461004e57806377cfd1711461006a578063cca2f7bc1461009a578063fb6200c6146100b6575b5f5ffd5b61006860048036038101906100639190610369565b6100d2565b005b610084600480360381019061007f91906103e3565b6100f6565b6040516100919190610439565b60405180910390f35b6100b460048036038101906100af91906104b3565b610115565b005b6100d060048036038101906100cb9190610553565b6101c4565b005b6100f3815f013582602001358380604001906100ee91906105d0565b6101d6565b50565b5f602052815f5260405f20602052805f5260405f205f91509150505481565b5f8282905090505f5b818110156101be576101b384848381811061013c5761013b610632565b5b905060200281019061014e919061065f565b5f013585858481811061016457610163610632565b5b9050602002810190610176919061065f565b6020013586868581811061018d5761018c610632565b5b905060200281019061019f919061065f565b80604001906101ae91906105d0565b6101d6565b80600101905061011e565b50505050565b6101d0848484846101d6565b50505050565b60018282905014610213576040517f2f59bd0d00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b5f5f1b82825f81811061022957610228610632565b5b9050602002013503610267576040517f9b5f85eb00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b5f5f1b5f5f8681526020019081526020015f205f8581526020019081526020015f2054146102c1576040517f2d48e8cf00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b81815f8181106102d4576102d3610632565b5b905060200201355f5f8681526020019081526020015f205f8581526020019081526020015f208190555082847f6b451b8422636e45b93bf7f594fa2c1769d039766c4254a6e7f9c0ee1715cdb084846040516103319291906106fe565b60405180910390a350505050565b5f5ffd5b5f5ffd5b5f5ffd5b5f606082840312156103605761035f610347565b5b81905092915050565b5f6020828403121561037e5761037d61033f565b5b5f82013567ffffffffffffffff81111561039b5761039a610343565b5b6103a78482850161034b565b91505092915050565b5f819050919050565b6103c2816103b0565b81146103cc575f5ffd5b50565b5f813590506103dd816103b9565b92915050565b5f5f604083850312156103f9576103f861033f565b5b5f610406858286016103cf565b9250506020610417858286016103cf565b9150509250929050565b5f819050919050565b61043381610421565b82525050565b5f60208201905061044c5f83018461042a565b92915050565b5f5ffd5b5f5ffd5b5f5ffd5b5f5f83601f84011261047357610472610452565b5b8235905067ffffffffffffffff8111156104905761048f610456565b5b6020830191508360208202830111156104ac576104ab61045a565b5b9250929050565b5f5f602083850312156104c9576104c861033f565b5b5f83013567ffffffffffffffff8111156104e6576104e5610343565b5b6104f28582860161045e565b92509250509250929050565b5f5f83601f84011261051357610512610452565b5b8235905067ffffffffffffffff8111156105305761052f610456565b5b60208301915083602082028301111561054c5761054b61045a565b5b9250929050565b5f5f5f5f6060858703121561056b5761056a61033f565b5b5f610578878288016103cf565b9450506020610589878288016103cf565b935050604085013567ffffffffffffffff8111156105aa576105a9610343565b5b6105b6878288016104fe565b925092505092959194509250565b5f5ffd5b5f5ffd5b5f5ffd5b5f5f833560016020038436030381126105ec576105eb6105c4565b5b80840192508235915067ffffffffffffffff82111561060e5761060d6105c8565b5b60208301925060208202360383131561062a576106296105cc565b5b509250929050565b7f4e487b71000000000000000000000000000000000000000000000000000000005f52603260045260245ffd5b5f8235600160600383360303811261067a576106796105c4565b5b80830191505092915050565b5f82825260208201905092915050565b5f5ffd5b82818337505050565b5f6106ae8385610686565b93507f07ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff8311156106e1576106e0610696565b5b6020830292506106f283858461069a565b82840190509392505050565b5f6020820190508181035f8301526107178184866106a3565b9050939250505056fea26469706673582212209947a4f0615e892247c992ba4bdf07b26d3f770db9fe5638a346c2685973b8c864736f6c634300081e0033


Should be used in tests if matter-labs/era-contracts#1644 will be merged and deployed

Dummy version of https://github.com/matter-labs/era-contracts/blob/010844292ad56b336cfbcebdc775d7e2ca1fb6f5/system-contracts/contracts/L2InteropRootStorage.sol

0xVolosnikov · 2025-11-21T21:50:28Z

basic_bootloader/src/bootloader/mod.rs

+
+    /// Calls the L2 interop root storage contract to register multiple interop roots in a single batch.
+    /// Returns updated resource limits after the contract call.
+    /// TODO: use after L2InteropRootStorage.sol supports corresponding functionality


We should use this function if matter-labs/era-contracts#1644 will be merged and deployed

It allows us to do just one call instead of 1 call per 1 root. Ideally we also want to wrap it as a formal system transaction. Otherwise it will emit events that will pollute the first tx in the block.

0xVolosnikov · 2025-11-21T21:51:37Z

tests/instances/eth_runner/src/single_run.rs

+    let mut block_context = block.get_block_context();
+
+    // To check benchmarks
+    // TODO remove


To be discussed. Maybe it makes sense to keep it to always have ~worst case in benchmarks

I think we can keep it, we basically don't use single run for anything other than our benches. Will be useful to catch any regression related to interop root processing

0xVolosnikov · 2025-11-21T21:56:19Z

basic_bootloader/src/bootloader/mod.rs

+        let (interop_roots, computational_native_used_for_interop_roots) =
+            Self::process_interop_roots(&mut system, &mut system_functions, &mut memories, tracer)?;
+        block_computational_native_used += computational_native_used_for_interop_roots;
+        // TODO pubdata used by interop roots


We should also count the pubdata used here. It would be easier with a formal tx, since we update storage slots, potentially emit events etc.

Also we should check for any side effects of this. E.g. state of the caches

0xVolosnikov · 2025-11-21T21:58:14Z

forward_system/src/run/mod.rs

        tx_data_responder,
        preimage_responder,
    } = dump;
+    // TODO also include interop roots


We should also include roots in the dump and then read them here

I think we can just remove those functions, we're not using them

0xVolosnikov · 2025-11-21T22:20:46Z

.github/workflows/ci.yml

              with:
                  repository: matter-labs/era-evm-tester
-                  ref: zk-ee-dev
+                  ref: vv-interop-roots


github-actions · 2025-11-24T06:14:08Z

Benchmark report

Benchmark	Symbol	Base Eff	Head Eff (%)	Base Raw	Head Raw (%)	Base Blake	Head Blake (%)	Base Bigint	Head Bigint (%)
`block_19299001`	`run_prepared`	310,890,699	313,127,100 (+0.72%)	268,224,923	270,461,004 (+0.83%)	410,610	410,630 (+0.00%)	9,024,004	9,024,004 (+0.00%)
`block_22244135`	`run_prepared`	191,047,906	193,698,117 (+1.39%)	164,131,846	166,781,737 (+1.61%)	172,020	172,040 (+0.01%)	6,040,935	6,040,935 (+0.00%)
`precompiles`	`bn254_ecadd`	53,197	53,197 (+0.00%)	47,745	47,745 (+0.00%)	0	0 (+0.00%)	1,363	1,363 (+0.00%)
`precompiles`	`bn254_ecmul`	731,034	731,034 (+0.00%)	566,846	566,846 (+0.00%)	0	0 (+0.00%)	41,047	41,047 (+0.00%)
`precompiles`	`bn254_pairing`	72,689,618	72,689,618 (+0.00%)	58,161,474	58,161,474 (+0.00%)	0	0 (+0.00%)	3,632,036	3,632,036 (+0.00%)
`precompiles`	`ecrecover`	477,151	478,789 (+0.34%)	309,771	310,909 (+0.37%)	0	0 (+0.00%)	41,845	41,970 (+0.30%)
`precompiles`	`id`	933	933 (+0.00%)	933	933 (+0.00%)	0	0 (+0.00%)	0	0 (+0.00%)
`precompiles`	`keccak`	137,578	137,578 (+0.00%)	137,578	137,578 (+0.00%)	0	0 (+0.00%)	0	0 (+0.00%)
`precompiles`	`modexp`	32,084,944	32,084,944 (+0.00%)	21,427,124	21,427,124 (+0.00%)	0	0 (+0.00%)	2,664,455	2,664,455 (+0.00%)
`precompiles`	`p256_verify`	750,769	750,769 (+0.00%)	472,077	472,077 (+0.00%)	0	0 (+0.00%)	69,673	69,673 (+0.00%)
`precompiles`	`point_evaluation`	51,158,394	51,158,394 (+0.00%)	39,535,766	39,535,766 (+0.00%)	0	0 (+0.00%)	2,905,657	2,905,657 (+0.00%)
`precompiles`	`process_transaction`	73,828,477	73,834,945 (+0.01%)	59,134,585	59,131,985 (-0.00%)	160	160 (+0.00%)	3,672,833	3,675,100 (+0.06%)
`precompiles`	`ripemd`	8,028	8,028 (+0.00%)	8,028	8,028 (+0.00%)	0	0 (+0.00%)	0	0 (+0.00%)
`precompiles`	`run_prepared`	148,148,706	148,160,675 (+0.01%)	118,682,202	118,690,015 (+0.01%)	5,070	5,070 (+0.00%)	7,346,346	7,347,385 (+0.01%)
`precompiles`	`sha256`	13,167	13,167 (+0.00%)	13,167	13,167 (+0.00%)	0	0 (+0.00%)	0	0 (+0.00%)
`precompiles`	`verify_and_apply_batch`	132,169	132,169 (+0.00%)	97,449	97,449 (+0.00%)	2,170	2,170 (+0.00%)	0	0 (+0.00%)

antoniolocascio · 2025-11-24T06:03:07Z

basic_bootloader/src/bootloader/mod.rs

+    where
+        S::IO: IOSubsystemExt,
+    {
+        let interop_roots = system.get_interop_roots().map_err(|x| wrap_error!(x))?;


Do we want to use Vec instead of ArrayVec (as done for 4844 hashes in #381 )?

antoniolocascio · 2025-11-24T06:19:30Z

forward_system/src/run/mod.rs

        tx_data_responder,
        preimage_responder,
    } = dump;
+    // TODO also include interop roots


I think we can just remove those functions, we're not using them

antoniolocascio and others added 15 commits November 19, 2025 14:51

Merge branch 'main' into dev

750c24b

Merge branch 'main' into dev

5397a12

Migrate interop PoC on top of current dev

909683a

Fix

53e11a5

Clippy

351380b

Move interop roots hashing out of public_input.rs

d6548f1

Fix test

205b8d1

Cleanup

6c13599

Add some tests for dynamic usize serialization

340b31b

Add comments, cleanup

b783313

Fix bench

f90d937

Add batch encoding (currently not used)

10339e1

Clippy

229da79

0xVolosnikov mentioned this pull request Nov 21, 2025

feat: enable interop for zksync-os #194

Closed

6 tasks

0xVolosnikov added 5 commits November 21, 2025 14:59

Fix for fuzzer

08377dc

Fix

f40bc98

Add test for a corner case

8e97005

Fix fuzzer

fa763da

Support interop roots from the interface

d09534c

0xVolosnikov commented Nov 21, 2025

View reviewed changes

Pin legacy tester

83312f3

0xVolosnikov commented Nov 21, 2025

View reviewed changes

antoniolocascio force-pushed the dev branch from 5397a12 to d9ffc39 Compare November 24, 2025 03:59

Merge remote-tracking branch 'public/dev' into vv-interop-initial

9e7f01c

antoniolocascio reviewed Nov 24, 2025

View reviewed changes

antoniolocascio mentioned this pull request Nov 26, 2025

feat: interop root processing via service transaction #427

Open

6 tasks

		@@ -0,0 +1 @@
		608060405234801561000f575f5ffd5b506004361061004a575f3560e01c80633b43dbde1461004e57806377cfd1711461006a578063cca2f7bc1461009a578063fb6200c6146100b6575b5f5ffd5b61006860048036038101906100639190610369565b6100d2565b005b610084600480360381019061007f91906103e3565b6100f6565b6040516100919190610439565b60405180910390f35b6100b460048036038101906100af91906104b3565b610115565b005b6100d060048036038101906100cb9190610553565b6101c4565b005b6100f3815f013582602001358380604001906100ee91906105d0565b6101d6565b50565b5f602052815f5260405f20602052805f5260405f205f91509150505481565b5f8282905090505f5b818110156101be576101b384848381811061013c5761013b610632565b5b905060200281019061014e919061065f565b5f013585858481811061016457610163610632565b5b9050602002810190610176919061065f565b6020013586868581811061018d5761018c610632565b5b905060200281019061019f919061065f565b80604001906101ae91906105d0565b6101d6565b80600101905061011e565b50505050565b6101d0848484846101d6565b50505050565b60018282905014610213576040517f2f59bd0d00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b5f5f1b82825f81811061022957610228610632565b5b9050602002013503610267576040517f9b5f85eb00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b5f5f1b5f5f8681526020019081526020015f205f8581526020019081526020015f2054146102c1576040517f2d48e8cf00000000000000000000000000000000000000000000000000000000815260040160405180910390fd5b81815f8181106102d4576102d3610632565b5b905060200201355f5f8681526020019081526020015f205f8581526020019081526020015f208190555082847f6b451b8422636e45b93bf7f594fa2c1769d039766c4254a6e7f9c0ee1715cdb084846040516103319291906106fe565b60405180910390a350505050565b5f5ffd5b5f5ffd5b5f5ffd5b5f606082840312156103605761035f610347565b5b81905092915050565b5f6020828403121561037e5761037d61033f565b5b5f82013567ffffffffffffffff81111561039b5761039a610343565b5b6103a78482850161034b565b91505092915050565b5f819050919050565b6103c2816103b0565b81146103cc575f5ffd5b50565b5f813590506103dd816103b9565b92915050565b5f5f604083850312156103f9576103f861033f565b5b5f610406858286016103cf565b9250506020610417858286016103cf565b9150509250929050565b5f819050919050565b61043381610421565b82525050565b5f60208201905061044c5f83018461042a565b92915050565b5f5ffd5b5f5ffd5b5f5ffd5b5f5f83601f84011261047357610472610452565b5b8235905067ffffffffffffffff8111156104905761048f610456565b5b6020830191508360208202830111156104ac576104ab61045a565b5b9250929050565b5f5f602083850312156104c9576104c861033f565b5b5f83013567ffffffffffffffff8111156104e6576104e5610343565b5b6104f28582860161045e565b92509250509250929050565b5f5f83601f84011261051357610512610452565b5b8235905067ffffffffffffffff8111156105305761052f610456565b5b60208301915083602082028301111561054c5761054b61045a565b5b9250929050565b5f5f5f5f6060858703121561056b5761056a61033f565b5b5f610578878288016103cf565b9450506020610589878288016103cf565b935050604085013567ffffffffffffffff8111156105aa576105a9610343565b5b6105b6878288016104fe565b925092505092959194509250565b5f5ffd5b5f5ffd5b5f5ffd5b5f5f833560016020038436030381126105ec576105eb6105c4565b5b80840192508235915067ffffffffffffffff82111561060e5761060d6105c8565b5b60208301925060208202360383131561062a576106296105cc565b5b509250929050565b7f4e487b71000000000000000000000000000000000000000000000000000000005f52603260045260245ffd5b5f8235600160600383360303811261067a576106796105c4565b5b80830191505092915050565b5f82825260208201905092915050565b5f5ffd5b82818337505050565b5f6106ae8385610686565b93507f07ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff8311156106e1576106e0610696565b5b6020830292506106f283858461069a565b82840190509392505050565b5f6020820190508181035f8301526107178184866106a3565b9050939250505056fea26469706673582212209947a4f0615e892247c992ba4bdf07b26d3f770db9fe5638a346c2685973b8c864736f6c634300081e0033 No newline at end of file

feat: Interop roots processing #419

Are you sure you want to change the base?

feat: Interop roots processing #419

Uh oh!

Conversation

0xVolosnikov commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What ❔

Why ❔

Is this a breaking change?

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xVolosnikov Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xVolosnikov Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xVolosnikov Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 24, 2025

Benchmark report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xVolosnikov commented Nov 21, 2025 •

edited

Loading

0xVolosnikov Nov 21, 2025 •

edited

Loading

0xVolosnikov Nov 21, 2025 •

edited

Loading

0xVolosnikov Nov 21, 2025 •

edited

Loading