for cdc : inject some faults and fix some bugs #22186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cabbage74
requested review from
LeftHandCold,
XuPeng-SH,
daviszhen,
qingxinhome,
ck89119 and
jiangxinmeng1
as code owners
jiangxinmeng1
pushed a commit
to jiangxinmeng1/matrixone
that referenced
this pull request
Aug 19, 2025
Some faults are injected in cdc. And the way to call handleNewTables is changed. Now there is at most one goroutine running handleNewTables. Otherwise, truncate info can be lost in some cases. And cdc sync will do once immediately no matter of the frequency. Approved by: @jiangxinmeng1, @qingxinhome, @ck89119, @XuPeng-SH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
2
issue #22185
issue #22211
What this PR does / why we need it:
Some faults are injected in cdc.
And the way to call handleNewTables is changed. Now there is at most one goroutine running handleNewTables. Otherwise, truncate info can be lost in some cases.
And cdc sync will do once immediately no matter of the frequency.