Skip to content

some code cleanup #21828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 21, 2025
Merged

some code cleanup #21828

merged 15 commits into from
May 21, 2025

Conversation

XuPeng-SH
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #20535

What this PR does / why we need it:

  1. Remove some unused code
  2. refactor some code

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label May 12, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot merged commit 40ed468 into matrixorigin:main May 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reusee reusee reusee approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@LeftHandCold LeftHandCold LeftHandCold approved these changes

@daviszhen daviszhen daviszhen approved these changes

@triump2020 triump2020 triump2020 approved these changes

@qingxinhome qingxinhome Awaiting requested review from qingxinhome

Assignees
No one assigned
Labels
size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XuPeng-SH @reusee @zhangxu19830126 @LeftHandCold @daviszhen @triump2020 @matrix-meow