Skip to content

Switch shutdown_room to delete room API #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Switch shutdown_room to delete room API #988

merged 2 commits into from
Dec 10, 2020

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Dec 9, 2020

Remove old shutdown_room admin API

Switch from /_synapse/admin/v1/shutdown_room/$room_id
to /_synapse/admin/v1/rooms/$room_id/delete

Follow up: matrix-org/synapse#8829
Required for: matrix-org/synapse#8830

@clokep clokep requested a review from a team December 10, 2020 12:06
clokep
clokep approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! 👍

@clokep clokep merged commit e345c72 into matrix-org:develop Dec 10, 2020
@dklimpel dklimpel deleted the deprecate_room_api branch February 24, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clokep clokep clokep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dklimpel @clokep