Skip to content

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 20, 2020

We use a high limit so the limit is never reached, but enabling the
limit ensures that the code paths get hit. This helps testing the
feature with worker mode.

c.f. matrix-org/synapse#6742

We use a high limit so the limit is never reached, but enabling the
limit ensures that the code paths get hit. This helps testing the
feature with worker mode.
@erikjohnston erikjohnston requested a review from a team January 20, 2020 16:17
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a high limit so the limit is never reached, but enabling the
limit ensures that the code paths get hit. This helps testing the
feature with worker mode.

this comment could do with being in the code.

lgtm otherwise.

@erikjohnston erikjohnston merged commit 679ef0b into develop Jan 28, 2020
anoadragon453 added a commit that referenced this pull request Mar 23, 2020
…ease-v1.10.x

* origin/release-v1.10.0:
  remove checks on m.room.aliases (#801)
  Remove test which uses unspecced /events?dir=b (#794)
  Add some tests to check for adding/removing aliases (#792)
  Add test for ensuring power levels are correctly handled during upgrade (#777)
  Test that fetching device correctly resyncs (#791)
  Add support for experimental MSC2260 room version (#790)
  Fix power levels being sent as strings (#789)
  Don't respond with 503 as server will be marked as down. (#788)
  Test Synapse with MAU limits enabled. (#782)
  Fix docker/push.sh and make it echo commands
  Change postgres in docker image to use C collation/ctype. (#783)
  Add a passing test for recovery from gappy device list updates (#761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants