Skip to content

Fix unsafe assertions for media api tests #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix unsafe assertions for media api tests #1353

merged 2 commits into from
Jun 15, 2023

Conversation

joshqou
Copy link
Contributor

@joshqou joshqou commented Jun 1, 2023

Fix assertions for unsafe behaviour blocking matrix-org/synapse/#15680.

@joshqou joshqou marked this pull request as ready for review June 1, 2023 13:36
@joshqou joshqou requested a review from a team as a code owner June 1, 2023 13:36
@clokep clokep linked an issue Jun 1, 2023 that may be closed by this pull request
Fix tests asserting unsafe media api behaviour #1352
Closed
@reivilibre reivilibre mentioned this pull request Jun 9, 2023
Merged
reivilibre
reivilibre approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle — we will need to merge this in sync with Dendrite and Synapse changes.

@reivilibre reivilibre self-assigned this Jun 9, 2023
@kegsay
Copy link
Member

kegsay commented Jun 15, 2023

I'm happy on the Dendrite side, ready to merge.

@reivilibre reivilibre merged commit bb77060 into matrix-org:develop Jun 15, 2023
@reivilibre reivilibre mentioned this pull request Jun 15, 2023
Merged
joshqou added a commit to joshqou/sytest that referenced this pull request Jun 15, 2023
@joshqou
02nofilename.pl: Fix test missed by matrix-org#1353
fa608e8
@joshqou
Copy link
Contributor Author

joshqou commented Jun 15, 2023

Seems I missed a test in 02nofilename.pl I thought I fixed, #1355 should fix that once it's out of draft.

erikjohnston pushed a commit that referenced this pull request Jun 16, 2023
@reivilibre
Change expectations of filenameless Content-Disposition (#1355)
0fc46a4 
Follows #1353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees

@reivilibre reivilibre

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix tests asserting unsafe media api behaviour

3 participants

@joshqou @kegsay @reivilibre