Drop --no-tls and clean up Homeserver object API #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now only used for federation, so rename it for clarity and for consistency with federation_port
The behaviour of this parameter was never terribly well defined, I don't think it's much use, and it significantly complicates the host/port setup.
Synapse and Dendrite still have `secure_port` methods which they use internally, but they no longer form part of the public interface. Maybe they should be renamed with underscores or something.
richvdh
force-pushed
the
rav/cleanup_homeserver_api
branch
from
137b83a to
040d812
Compare
|
Looks like a nice clean-up! 👍 Thanks! The dendrite builds are soft-failing on this branch, it looked like only a few tests were failing though. Maybe @neilalexander knows what's going on? |
|
It looks to me like the same tests are failing here as on develop (see https://buildkite.com/matrix-dot-org/sytest/builds/1297), so I think those are separate problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was getting to be a bit of a mess, with unused/duplicate functions, and undocumented methods named the same as undocumented fields with different functions. Clean it all up.
Commits should be reviewable independently.