This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Prevent bundling aggregations for state events #9616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/bundle_aggregations_state
branch
from
1442c8d to
0dfb86b
Compare
We're trying this out on hotfixes to see whether it helps address performance issues. There's no need to do aggregation bundling for state events anyways.
If its not necessary then let's just land it on mainline? |
|
Closed in favour of a mainline implementation: #9619 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying this out on hotfixes to see whether it helps address
performance issues. There's no need to do aggregation bundling for
state events anyways.
Note: mypy CI failure is unrelated.