Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove : from allowed client_secret chars #8101

Merged
merged 8 commits into from
Aug 18, 2020
Merged

Remove : from allowed client_secret chars #8101

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d95bd3b
Remove : from allowed client_secret chars
anoadragon453 Aug 17, 2020
f8e1388
Changelog
anoadragon453 Aug 17, 2020
da179df
Add warning to CHANGES.md
anoadragon453 Aug 17, 2020
ab9b4b8
Remove : as an allowed character in stringutils test
anoadragon453 Aug 17, 2020
d3134cc
Update CHANGES.md
anoadragon453 Aug 17, 2020
ff184de
Merge branch 'anoa/remove_colon_client_secret' of github.com:matrix-o…
anoadragon453 Aug 17, 2020
27f76ae
better engerish in CHANGES.md
anoadragon453 Aug 17, 2020
59347e8
removal -> bugfix
anoadragon453 Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
For the next release
====================

Removal warning
---------------

Some older clients added `:` to the `client_secret` parameter of various endpoints, however the
Client-Server API specification
[disallows this](https://matrix.org/docs/spec/client_server/unstable#post-matrix-client-r0-register-email-requesttoken).
Adding `:` in a `client_secret` string has been allowed for some time to allow that client to update,
and we are now removing it, as most users have updated. Further context can be found at https://github.com/matrix-org/synapse/issues/6766.

We are not currently aware of any other clients that send incorrect `client_secret` values.


Synapse 1.19.0 (2020-08-17)
===========================

Expand Down