Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add 'rel' attribute to default welcome page. #5695

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Add 'rel' attribute to default welcome page. #5695

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2be8b3
add rel attribute as a precaution against reverse tabnabbing in future
neilisfragile Jul 16, 2019
c3a82e6
towncrier
neilisfragile Jul 16, 2019
a99c103
Rename 5695.feature to 5695.misc
richvdh Jul 19, 2019
67f1c87
Update 5695.misc
richvdh Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5695.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add precautionary measures to prevent future abuse of window.opener in index.html.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably put this as .misc tbh

4 changes: 2 additions & 2 deletions synapse/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@
</div>
<h1>It works! Synapse is running</h1>
<p>Your Synapse server is listening on this port and is ready for messages.</p>
<p>To use this server you'll need <a href="https://matrix.org/docs/projects/try-matrix-now.html#clients" target="_blank">a Matrix client</a>.
<p>To use this server you'll need <a href="https://matrix.org/docs/projects/try-matrix-now.html#clients" target="_blank" rel="noopener noreferrer">a Matrix client</a>.
</p>
<p>Welcome to the Matrix universe :)</p>
<hr>
<p>
<small>
<a href="https://matrix.org" target="_blank">
<a href="https://matrix.org" target="_blank" rel="noopener noreferrer">
matrix.org
</a>
</small>
Expand Down