Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5616.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make runtime errors surrounding password reset emails much clearer.
12 changes: 7 additions & 5 deletions synapse/config/emailconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ def read_config(self, config, **kwargs):

if len(missing) > 0:
raise RuntimeError(
"email.password_reset_behaviour is set to 'local' "
"but required keys are missing: %s"
"Password resets emails are configured to be sent from "
"this homeserver due to a partial email block. "
"However, the following required keys are missing: %s"
% (", ".join(["email." + k for k in missing]),)
)

Expand Down Expand Up @@ -158,9 +159,10 @@ def read_config(self, config, **kwargs):

if config.get("public_baseurl") is None:
raise RuntimeError(
"email.password_reset_behaviour is set to 'local' but no "
"public_baseurl is set. This is necessary to generate password "
"reset links"
"Password resets emails will be sent from this homeserver "
"due to a configured email block. However, no "
"public_baseurl is set. "
"This is necessary to generate password reset links"
)

if self.email_enable_notifs:
Expand Down