This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Revert "Reintroduce membership tables event stream ordering" #15347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6af49f.
|
I'm going to merge this to allow us to deploy develop on matrix.org |
erikjohnston
deleted the
revert-15128-membership-tables-event-stream-ordering-redux
branch
|
Ouch. I didn’t think adding columns required locks in postgres? Not sure how best to proceed for this |
Fizzadar
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Mar 30, 2023
…atrix-org#15128)" (matrix-org#15347)" This reverts commit 5350b5d.
4 tasks
Fizzadar
added a commit
to Fizzadar/synapse
that referenced
this pull request
Apr 20, 2023
…atrix-org#15128)" (matrix-org#15347)" This reverts commit 5350b5d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15128
cc. @Fizzadar
The
ALTER TABLEtook a long time on matrix.org (multiple minutes before being cancelled), while holding a lock that blocked all message sending