Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Use mypy 1.0 #15052

Merged
merged 19 commits into from
Feb 16, 2023
Merged

Use mypy 1.0 #15052

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
325daae
Update mypy and mypy-zope
Feb 10, 2023
408935c
Suppress false positives from modules not implementing Protocols
Feb 9, 2023
d584aeb
Remove unused ignores
Feb 9, 2023
07d96ca
Avoid empty body warnings
Feb 9, 2023
1f00d57
Suppress false positive about `JaegerConfig`
Feb 9, 2023
57861a8
Fix not calling `is_state()`
Feb 9, 2023
9d1d8a6
Suppress false positives from ParamSpecs
Feb 9, 2023
b63789a
Drive-by improvement to `wrapping_logic` annotation
Feb 9, 2023
212897e
Workaround false "unreachable" positives
Feb 10, 2023
a7c2bc3
Changelog
Feb 10, 2023
852b3fc
Linter fixes
Feb 10, 2023
8395cc8
Make UserInteractiveAuthChecker an ABC
Feb 15, 2023
f351967
Make Responder an ABC
Feb 15, 2023
29dd442
Mark EventSource as an ABC
Feb 15, 2023
e9329dc
Tweak DBAPI2 Protocol to be accepted by mypy 1.0
Feb 15, 2023
029cfaf
Pull in updated canonicaljson lib
Feb 15, 2023
14db7d4
Improve comments in opentracing
Feb 16, 2023
b739beb
Better annotation for INTERACTIVE_AUTH_CHECKERS
Feb 16, 2023
7612a88
Drive-by AUTH_TYPE annotation, to remove an ignore
Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions synapse/logging/opentracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,10 @@ def _decorator(func: Callable[P, R]) -> Callable[P, R]:
if not opentracing:
return func

return _custom_sync_async_decorator(func, _wrapping_logic)
# type-ignore: mypy seems to be confused by the ParamSpecs here.
return _custom_sync_async_decorator(
func, _wrapping_logic # type: ignore[arg-type]
)

return _decorator

Expand Down Expand Up @@ -1010,7 +1013,8 @@ def _wrapping_logic(
set_tag(SynapseTags.FUNC_KWARGS, str(kwargs))
yield

return _custom_sync_async_decorator(func, _wrapping_logic)
# type-ignore: mypy seems to be confused by the ParamSpecs here.
return _custom_sync_async_decorator(func, _wrapping_logic) # type: ignore[arg-type]


@contextlib.contextmanager
Expand Down