Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Push complement image to a docker registry #14509

Merged
merged 16 commits into from
Nov 28, 2022
Merged

Push complement image to a docker registry #14509

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
05d3ca1
GHA workflow to build complement images of key branches.
michaelkaye Nov 21, 2022
240087e
Add changelog.d
michaelkaye Nov 21, 2022
d0a007f
GHA workflow to build complement images of key branches.
michaelkaye Nov 21, 2022
5fdeac3
Add changelog.d
michaelkaye Nov 21, 2022
7f55ed7
Update complement.yml
michaelkaye Nov 23, 2022
22f1b7e
Merge branch 'develop' into michaelk/push_complement_image
michaelkaye Nov 23, 2022
c357525
Update complement.yml
michaelkaye Nov 23, 2022
3b2348d
Rename file to be more obvious
michaelkaye Nov 24, 2022
b5f707b
Merge branch 'michaelk/push_complement_image' of github.com:michaelka…
michaelkaye Nov 24, 2022
45c5fd3
Merge did not go correctly.
michaelkaye Nov 24, 2022
5174c34
Setup 5am builds of develop, limit to one run at once.
michaelkaye Nov 25, 2022
ac00139
Fix crontab---run once at 5AM, not very minute between 5 and 6
DMRobertson Nov 28, 2022
22abe0d
Fix cron syntax again?
DMRobertson Nov 28, 2022
7daa053
Tweak workflow name
Nov 28, 2022
608e814
Allow manual debug runs
Nov 28, 2022
95c6943
Tweak indentation
Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/complement.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# This task does not run complement tests, see tests.yaml instead.
# This task does not build docker images for synapse for use on docker hub, see docker.yaml instead

name: Store complement synapse image in ghcr.io
on:
push:
branches: ["master", "develop"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is basically entirely up to you, but do you want to push images for tagged releases?
I could see it maybe being useful for comparing different releases if necessary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for bridges, we've only got the CI bandwidth for doing so many tests, so we're just doing master (and soon develop) for the moment. The idea is to test against latest stable, and also ensuring any new changes landing in Synapse don't break stuff (or vice versa).

Release testing would be nice if we had named supported versions of synapse though.

Copy link
Contributor Author

@michaelkaye michaelkaye Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my test cases, we probably only want to test current and next as well; if people want to investigate certain synapse versions then that can happen as a local build for now.

(Adding more options can come as required.)

jobs:
build:
name: Build and push complement image
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
steps:
- name: Checkout clean copy
uses: actions/checkout@v3
- name: Login to registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Work out labels for complement image
id: meta
uses: docker/metadata-action@v1
with:
images: ghcr.io/${{ github.repository }}/complement-synapse
- name: Build complement image
run: scripts-dev/complement.sh --build-only
- name: Tag and push generated image
run: |
for TAG in ${{ steps.meta.outputs.tags }}; do
docker tag complement-synapse:latest $TAG
docker push $TAG
done
1 change: 1 addition & 0 deletions changelog.d/14509.docker
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Push complement-synapse docker images to ghcr.io repository.