Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Improve startup times in Complement test runs against workers, particularly in CPU-constrained environments. #13127

Merged
merged 15 commits into from
Jun 30, 2022
Merged

Improve startup times in Complement test runs against workers, particularly in CPU-constrained environments. #13127

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
71e515b
Add a fork()-based launcher for Synapse for use in Complement test runs
reivilibre Jun 28, 2022
7b4b517
Don't pick out the run method from the reactor at import time
reivilibre Jun 28, 2022
47be453
Update supervisor config to use the forking launcher when we want to
reivilibre Jun 28, 2022
a8308cc
Add worker names to the log lines when using fork launcher
reivilibre Jun 28, 2022
089f4b3
Control use of fork()-based launcher with an env var
reivilibre Jun 28, 2022
757d66c
Newsfile
reivilibre Jun 28, 2022
8669ff3
Test against workers in CI every time! :-)
reivilibre Jun 28, 2022
37bf9d0
Add comments about run() not being bound early
reivilibre Jun 29, 2022
caab855
Remove leading underscore from complement_fork_starter
reivilibre Jun 29, 2022
f3dc1c4
Rename ___install to _install_real_reactor
reivilibre Jun 29, 2022
8f7e96e
Move comment to where we actually use fork()
reivilibre Jun 29, 2022
c475b00
Use argparse to do the first split of arguments and to provide help text
reivilibre Jun 29, 2022
d677e52
Remove stray #
reivilibre Jun 29, 2022
821b473
Update synapse/app/_base.py
reivilibre Jun 30, 2022
3bd858f
Pull out things from `ns` at point of use
reivilibre Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions synapse/app/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def register_sighup(func: Callable[P, None], *args: P.args, **kwargs: P.kwargs)
def start_worker_reactor(
appname: str,
config: HomeServerConfig,
run_command: Callable[[], None] = reactor.run,
run_command: Callable[[], None] = lambda: reactor.run(),
) -> None:
"""Run the reactor in the main process

Expand Down Expand Up @@ -141,7 +141,7 @@ def start_reactor(
daemonize: bool,
print_pidfile: bool,
logger: logging.Logger,
run_command: Callable[[], None] = reactor.run,
run_command: Callable[[], None] = lambda: reactor.run(),
) -> None:
"""Run the reactor in the main process

Expand Down