Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

ANALYZE new stream ordering column #10326

Merged
merged 8 commits into from
Jul 7, 2021
+11 −0
Merged

ANALYZE new stream ordering column #10326

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d2875f
ANALYZE new stream ordering column
babolivier Jul 6, 2021
f6965f4
Changelog
babolivier Jul 6, 2021
3d9d3bc
Fix changelog name
babolivier Jul 6, 2021
a817acd
Run in a separate transaction
babolivier Jul 6, 2021
731778f
Update synapse/storage/databases/main/events_bg_updates.py
babolivier Jul 6, 2021
a6fafb9
Lint
babolivier Jul 6, 2021
c8ac366
remove useless function
babolivier Jul 6, 2021
849e7fd
Prevent execute from calling fetchall
babolivier Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/10326.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a long-standing bug where Synapse would return errors after 2<sup>31</sup> events were handled by the server.
8 changes: 8 additions & 0 deletions synapse/storage/databases/main/events_bg_updates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,6 +1146,14 @@ def process(txn: Cursor) -> None:
logger.info("completing stream_ordering migration: %s", sql)
txn.execute(sql)

# ANALYZE the new column to build stats on it, to encourage PostgreSQL to use the
# indexes on it.
await self.db_pool.execute(
"background_analyze_new_stream_ordering_column",
None,
"ANALYZE events(stream_ordering2)",
)

await self.db_pool.runInteraction(
"_background_replace_stream_ordering_column", process
)
Expand Down