rip out tls_fingerprints option from homeserver.yaml

[richvdh]

this option has no use any more and we should get rid of it and any code that reads it.

[jerinjtitus]

In tls.py, do I have to remove this whole function or just a part of it?

synapse/synapse/config/tls.py

Lines 229 to 252 in f2c1560

	def read_certificate_from_disk(self, require_cert_and_key: bool):
	"""
	Read the certificates and private key from disk.
	Args:
	require_cert_and_key: set to True to throw an error if the certificate
	and key file are not given
	"""
	if require_cert_and_key:
	self.tls_private_key = self.read_tls_private_key()
	self.tls_certificate = self.read_tls_certificate()
	elif self.tls_certificate_file:
	# we only need the certificate for the tls_fingerprints. Reload it if we
	# can, but it's not a fatal error if we can't.
	try:
	self.tls_certificate = self.read_tls_certificate()
	except Exception as e:
	logger.info(
	"Unable to read TLS certificate (%s). Ignoring as no "
	"tls listeners enabled.",
	e,
	)
	self.tls_fingerprints = list(self._original_tls_fingerprints)

I am working on other parts of code where tls_fingerprints is mentioned too.

[richvdh]

any code that is no longer used should be removed.

In this case, Config.tls_fingerprints is only used in synapse.rest.key.v2.local_key_resource.LocalKey, where it only used to set a feild that is no longer required in the Matrix protocol. So it can be removed from there, and the code that sets it can also be removed.

tls_certificate is still used: why would you want to remove that code?

[jerinjtitus]

tls_certificate is still used: why would you want to remove that code?

I was just confirming, due to the comment # we only need the certificate for the tls_fingerprints. Reload it if we. I wasn't sure if it was just reading that part of the certificate or whole of it.