This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Read receipts on element web are broken #12669
Copy link
Copy link
Closed
Labels
S-MajorMajor functionality / product severely impaired, no satisfactory workaround.Major functionality / product severely impaired, no satisfactory workaround.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Bugs, crashes, hangs, security vulnerabilities, or other reported issues.X-RegressionSomething broke which worked on a previous releaseSomething broke which worked on a previous releaseX-Release-BlockerMust be resolved before making a releaseMust be resolved before making a release
Description
Broke by #12168. Element web sends a hidden read receipt type, which Synapse doesn't understand and so 400s:
synapse/synapse/rest/client/read_marker.py
Lines 57 to 63 in 0ce2201
if set(body.keys()) > valid_receipt_types: | |
raise SynapseError( | |
400, | |
"Receipt type must be 'm.read', 'org.matrix.msc2285.read.private' or 'm.fully_read'" | |
if self.config.experimental.msc2285_enabled | |
else "Receipt type must be 'm.read' or 'm.fully_read'", | |
) |
This is a problem as it stops the other receipt types from being persisted.
We shouldn't be denying unknown receipt types.
Metadata
Metadata
Assignees
Labels
S-MajorMajor functionality / product severely impaired, no satisfactory workaround.Major functionality / product severely impaired, no satisfactory workaround.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Bugs, crashes, hangs, security vulnerabilities, or other reported issues.X-RegressionSomething broke which worked on a previous releaseSomething broke which worked on a previous releaseX-Release-BlockerMust be resolved before making a releaseMust be resolved before making a release