Skip to content

Module template retrofit: Fix up type annotations and enable Mypy type checking in GHA CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 30, 2021
Merged

Module template retrofit: Fix up type annotations and enable Mypy type checking in GHA CI #145

merged 3 commits into from
Dec 30, 2021

Conversation

reivilibre
Copy link
Contributor

No description provided.

@reivilibre reivilibre changed the title Module template retrofit: Fix up type annotations and enable Mypy type checking Module template retrofit: Fix up type annotations and enable Mypy type checking in GHA CI Dec 30, 2021
@reivilibre
Copy link
Contributor Author

At this point we have to say goodbye to BuildKite. I think it will be fine to turn them off once #147 merges?

@reivilibre reivilibre marked this pull request as ready for review December 30, 2021 17:48
@reivilibre reivilibre requested a review from a team as a code owner December 30, 2021 17:48
clokep
clokep reviewed Dec 30, 2021
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. I'm guessing this is what makes us not compatible with Python 3.5? We should update the identifiers at this point to make that explicit.

@reivilibre
Copy link
Contributor Author

I've now cut out the compatibility for BuildKite (including declaring the minimum Python version of 3.7): I intend to deactivate the BuildKite webhook when merging this so that CI isn't everfailing.
Sound fine?

@reivilibre reivilibre merged commit 96c0d84 into main Dec 30, 2021
@reivilibre reivilibre deleted the rei/mypy_main_fixup branch December 30, 2021 18:15
@reivilibre reivilibre mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@clokep clokep clokep approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reivilibre @clokep