Skip to content

Update CI to use Python 3.5 and switch to Buildkite #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 27, 2020
Merged

Update CI to use Python 3.5 and switch to Buildkite #103

merged 8 commits into from
Aug 27, 2020

Conversation

reivilibre
Copy link
Contributor

Prior to this, it used Python 2.7.

@reivilibre reivilibre requested a review from a team August 25, 2020 13:42
clokep
clokep reviewed Aug 25, 2020
View reviewed changes
@reivilibre
Copy link
Contributor Author

I'm now using the tox-travis plugin which seems to work quite well, is that fine?

@reivilibre reivilibre requested a review from clokep August 26, 2020 10:19
clokep
clokep approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I pushed another commit with very minor changes.

Let's give people a minute in #synapse-dev:matrix.org to give opinions on tox-travis, but I think it is fine.

@clokep
Copy link
Member

clokep commented Aug 26, 2020

Although it was brought up of whether we should be converting this to buildkite instead?

@reivilibre
Copy link
Contributor Author

Switched to Buildkite. Fail above is because the pipeline isn't enabled yet.

@reivilibre reivilibre changed the title Update CI to use Python 3.5 Update CI to use Python 3.5 and switch to Buildkite Aug 26, 2020
@reivilibre reivilibre requested a review from clokep August 26, 2020 18:58
@reivilibre reivilibre merged commit 5abd2ac into master Aug 27, 2020
@clokep clokep deleted the rei/ci_fix branch August 27, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@clokep clokep clokep approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@reivilibre reivilibre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reivilibre @clokep