Spec PR - MSC3266: Room Summary API #2125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
changed the title
aine-etke
added a commit
to etkecc/mrs
that referenced
this pull request
May 29, 2025
…merged, and will be accepted into the spec shortly, ref: matrix-org/matrix-spec#2125
clokep
reviewed
May 29, 2025
| - type: object | ||
| properties: | ||
| room_type: | ||
| x-addedInMatrixVersion: # Overrides room_summary.yaml |
There was a problem hiding this comment.
room_summary.yaml doesn't seem to define this anymore.
There was a problem hiding this comment.
Good catch, thanks. I restored x-addedInMatrixVersion: "1.4".
There was a problem hiding this comment.
Would it make more sense to add the 1.4 into the hierarcy endpoint and treat this as all the data?
There was a problem hiding this comment.
Oh! Actually, yes, setting the version only where it's needed is much less confusing than setting it in the central place and then unsetting it where it's not needed. Have made it so. Thanks for the suggestion.
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
force-pushed
the
johannes/msc3266
branch
from
8131b93 to
de6a7c6
Compare
Johennes
force-pushed
the
johannes/msc3266
branch
from
de6a7c6 to
bf47879
Compare
clokep
approved these changes
Jun 3, 2025
|
Looks great. Thank you! |
This was referenced Jun 7, 2025
34 tasks
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec for MSC3266.
Piecing the information together from the MSC and weaving it into the existing publicRooms / hierarchy relationship was slightly nightmarish. Hopefully I haven't missed anything. A thorough review would be appreciated in any case.
Pull Request Checklist
Preview: https://pr2125--matrix-spec-previews.netlify.app