Update spec for MSC3952: intentional mentions #1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
May 2, 2023
clokep
commented
May 2, 2023
clokep
force-pushed
the
intentional-mentions
branch
from
d7dbae2 to
095baab
Compare
clokep
force-pushed
the
intentional-mentions
branch
from
095baab to
45261ea
Compare
clokep
commented
May 3, 2023
|
I think this is going to need a bit more work, but it is ready for an initial round of review. |
MTRNord
reviewed
May 9, 2023
Co-authored-by: Marcel <[email protected]>
anoadragon453
previously requested changes
May 11, 2023
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
|
@richvdh Thank you very much for the review! I'm quite sure this will need a bit more back and forth, but I've handled your comments or replied to them (I've left open the threads I consider unresolved). Please take another look at your leisure! |
richvdh
reviewed
May 17, 2023
Co-authored-by: Richard van der Hoff <[email protected]>
|
@richvdh I've handled all those comments! I'm not sure if there's anything to do about the special behavior discussed in #1508 (comment), however. |
Yes, this is probably the best we can do for now. |
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MSC3952.
Preview: https://pr1508--matrix-spec-previews.netlify.app