MSC4289: Explicitly privilege room creators #4289
Merged
+194
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
proposal
|
(for clarity: this is using the process defined by matrix-org/matrix-spec#2157) |
turt2live
added
proposal-placeholder
github-project-automation
bot
moved this to Tracking for review
in Spec Core Team Workflow
turt2live
moved this from Tracking for review
to Ready for general review
in Spec Core Team Workflow
turt2live
moved this from Ready for general review
to In FCP
in Spec Core Team Workflow
turt2live
changed the title
turt2live
added
requires-room-version
|
This proposal completed FCP in an embargoed setting, and is now accepted. |
turt2live
added
the
action-required
|
When the embargo disclosure lifts, the merged copy of the MSC will be updated accordingly. |
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 23, 2025
Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289).
4 tasks
|
Spec PR is a WIP out of band by me. |
|
Spec PR is now in review (and open) out of band. |
turt2live
added
spec-pr-in-review
turt2live
moved this from Requires spec writing
to Requires spec PR review
in Spec Core Team Workflow
|
For clarity: this MSC has been assigned to room version 12. |
turt2live
reviewed
Jul 29, 2025
Comment on lines
+178
to
+190
| (Embargoed until Aug 11, 2025) | ||
|
|
||
| ### Security Considerations | ||
|
|
||
| (Embargoed until Aug 11, 2025) | ||
|
|
||
| ### Credits | ||
|
|
||
| Thanks to Timo Kösters for initiating discussion around this MSC. | ||
|
|
||
| ### Unstable prefix | ||
|
|
||
| During development this room version is referred to as `org.matrix.hydra.11` alongside MSC4291 and MSC4297 (embargoed until Aug 11, 2025). |
There was a problem hiding this comment.
hmm, I didn't seem to mention it at the time (sorry), but these dates were fixed in #4314 to be August 14th instead.
| - The new room does not have Alice as a creator or additional creator. | ||
|
|
||
| This allows the creator status to move between users. | ||
|
|
There was a problem hiding this comment.
This section is updated by #4315
3 tasks
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Aug 8, 2025
* Support for creator power level Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289). * Update unit test * Hardcode versions as room versions strings aren't ordered * Add test for v12 rooms * Use more compact syntax Co-authored-by: R Midhun Suresh <[email protected]> * Fix doc Co-authored-by: R Midhun Suresh <[email protected]> * Fix additionalCreators from PR edit * Split out hydra room version check * Move power level logic into room state Which already has knowledge of the room create event * Add docs * Fix unused bits * Fix docs * Fix lying docstring * Reverse logic for hydra semantics Assume unknown room versions do use hydra * Use backticks Co-authored-by: Richard van der Hoff <[email protected]> * Switch back to hardcoding just the two hydra versions --------- Co-authored-by: R Midhun Suresh <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
RiotRobot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Aug 8, 2025
* Support for creator power level Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289). * Update unit test * Hardcode versions as room versions strings aren't ordered * Add test for v12 rooms * Use more compact syntax Co-authored-by: R Midhun Suresh <[email protected]> * Fix doc Co-authored-by: R Midhun Suresh <[email protected]> * Fix additionalCreators from PR edit * Split out hydra room version check * Move power level logic into room state Which already has knowledge of the room create event * Add docs * Fix unused bits * Fix docs * Fix lying docstring * Reverse logic for hydra semantics Assume unknown room versions do use hydra * Use backticks Co-authored-by: Richard van der Hoff <[email protected]> * Switch back to hardcoding just the two hydra versions --------- Co-authored-by: R Midhun Suresh <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> (cherry picked from commit e119bf9)
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Aug 8, 2025
* Support for creator power level Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289). * Update unit test * Hardcode versions as room versions strings aren't ordered * Add test for v12 rooms * Use more compact syntax * Fix doc * Fix additionalCreators from PR edit * Split out hydra room version check * Move power level logic into room state Which already has knowledge of the room create event * Add docs * Fix unused bits * Fix docs * Fix lying docstring * Reverse logic for hydra semantics Assume unknown room versions do use hydra * Use backticks * Switch back to hardcoding just the two hydra versions --------- (cherry picked from commit e119bf9) Co-authored-by: David Baker <[email protected]> Co-authored-by: R Midhun Suresh <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
turt2live
reviewed
Aug 14, 2025
|
|
||
| ### Alternatives | ||
|
|
||
| (Embargoed until Aug 11, 2025) |
There was a problem hiding this comment.
Embargoed sections are added in #4328
turt2live
added
merged
|
Merged 🎉 |
|
The Room Administration page links here from this sentence:
How the hell am I supposed to do that? There's no explanation anywhere in the documentation. |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
(Written by Matthew as Matrix project lead (while on the clock as Element CTO) and Kegan as Element staff eng)
Process note: This MSC completed FCP in an embargoed setting. The embargoed sections will be updated once disclosed.
See https://matrix.org/blog/2025/07/security-predisclosure/ for details.