Skip to content

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Mar 21, 2025

Rendered


In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am a Systems Architect at gematik, Software Engineer at Filament and Unomed, Matrix community member and former Element employee. This proposal was written and published with my gematik hat on.

@Johennes Johennes changed the title MSCXXXX: Harmonizing the reporting endpoints MSC4277: Harmonizing the reporting endpoints Mar 21, 2025
@Johennes Johennes force-pushed the johannes/reporting-harmonization branch from 42df948 to 0f9c41e Compare March 21, 2025 10:03
@Johennes Johennes marked this pull request as ready for review March 21, 2025 10:08
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Mar 21, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200 regardless of event / room existence: element-hq/synapse#18263

I'm unsure if the random delay / constant time part requires an implementation. The spec already mentions this for the event reporting endpoint but Synapse doesn't appear to implement it and it's not part of element-hq/synapse#18120 either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the removal of score into element-hq/synapse#18263. Synapse didn't do anything else than assert the type anyway.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in continuwuity #919.

@Johennes Johennes requested a review from turt2live March 24, 2025 07:07

## Potential issues

The `reason` field on the room and user reporting endpoints is currently
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I find it bizarre that reason is required but may be empty string. I suppose this might not be the MSC to change it, but I'd rather we just made it optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand the value of requiring it to be filled for spam protection. The combination of required but allowed to be empty strikes me as slightly odd, too, but it's hard to judge without knowing T&S's future plans for the field.

Generally though, I suppose if we later go from required but possibly empty to required and not empty, it'll be just as much a breaking change for clients as if we went from optional to required and not empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to say. Even if the field was required people could just keyboard smash the field. I'm not really going to die on this hill though, I just think we should unify it in one direction.

My feeling for T&S that any report is a useful report, and that tooling is smart enough these days that we can make use of the room_id / event_id to do preliminary investigations even if the reason context isn't useful.

MadLittleMods pushed a commit to element-hq/synapse that referenced this pull request Jul 9, 2025
@github-project-automation github-project-automation bot moved this to Tracking for review in Spec Core Team Workflow Aug 5, 2025
@turt2live turt2live moved this from Tracking for review to Proposed for FCP readiness in Spec Core Team Workflow Aug 5, 2025
@turt2live turt2live self-assigned this Aug 6, 2025
@turt2live
Copy link
Member

This MSC has been put forward as potentially ready for FCP. T&S is aware of some features which may need mirroring to the trio of endpoints, and may want to include them in this MSC (the MSC hasn't been reviewed to see if they're already addressed).

Next steps are for T&S to review the MSC, then send it for SCT review. Feel free to ping me on either if the process takes too long.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 7, 2025
Tested on NetBSD 9 amd64 (federation, multiple clients)

# Synapse 1.135.0 (2025-08-01)

## Features

- Add `recaptcha_private_key_path` and `recaptcha_public_key_path` config option. ([\#17984](element-hq/synapse#17984), [\#18684](element-hq/synapse#18684))
- Add plain-text handling for rich-text topics as per [MSC3765](matrix-org/matrix-spec-proposals#3765). ([\#18195](element-hq/synapse#18195))
- If enabled by the user, server admins will see [soft failed](https://spec.matrix.org/v1.13/server-server-api/#soft-failure) events over the Client-Server API. ([\#18238](element-hq/synapse#18238))
- Add experimental support for [MSC4277: Harmonizing the reporting endpoints](matrix-org/matrix-spec-proposals#4277). ([\#18263](element-hq/synapse#18263))
- Add ability to limit amount of media uploaded by a user in a given time period. ([\#18527](element-hq/synapse#18527))
- Enable workers to write directly to the device lists stream and handle device list updates, reducing load on the main process. ([\#18581](element-hq/synapse#18581))
- Support arbitrary profile fields. Contributed by @clokep. ([\#18635](element-hq/synapse#18635))
- Advertise support for Matrix v1.12. ([\#18647](element-hq/synapse#18647))
- Add an option to issue redactions as an admin user via the [admin redaction endpoint](https://element-hq.github.io/synapse/latest/admin_api/user_admin_api.html#redact-all-the-events-of-a-user). ([\#18671](element-hq/synapse#18671))
- Add experimental and incomplete support for [MSC4306: Thread Subscriptions](https://github.com/matrix-org/matrix-spec-proposals/blob/rei/msc_thread_subscriptions/proposals/4306-thread-subscriptions.md). ([\#18674](element-hq/synapse#18674))
- Include `event_id` when getting state with `?format=event`. Contributed by @tulir @ Beeper. ([\#18675](element-hq/synapse#18675))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
Status: Proposed for FCP readiness
Development

Successfully merging this pull request may close these issues.

4 participants