Skip to content

MSC2998: Room Version 7 #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: MSC4294: Ignore and mass ignore invites
merged 6 commits into from
Mar 1, 2021
Merged

MSC2998: Room Version 7 #2998

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3735def
Define room version 7
anoadragon453 Feb 5, 2021
1f07f0d
MSC2998
anoadragon453 Feb 8, 2021
336e5a2
v6 -> v7
anoadragon453 Feb 8, 2021
97109d4
Remove MSC2175, MSC2174 due to lack of implementation
anoadragon453 Feb 18, 2021
fadee27
Alter to reserve v7 instead of declare v7
turt2live Feb 22, 2021
2acc0a6
Clarify prose
anoadragon453 Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions proposals/2998-rooms-v7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# MSCXXXX: Room Version 7

A new room version, `7`, is proposed using [room version 6](https://matrix.org/docs/spec/rooms/v6.html) as a base
and incorporating the following MSCs:

* [MSC2174](https://github.com/matrix-org/matrix-doc/pull/2174) - Move the `redacts` key to a sane place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in having two migrations of redaction format, we should just skip this step and go straight for mass redactions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tulir I didn't include Mass Redactions as it doesn't currently have an implementation.

You're right in that putting MSC2244 and MSC2174, especially as the former builds on the latter, into the same room version makes sense though. I'd be happy to review/help with a Synapse PR for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, doesn't content.redacts have to be protected from redaction now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is protected from redaction by MSC2176, that part works the same way for MSC2174 and MSC2244.

* [MSC2175](https://github.com/matrix-org/matrix-doc/pull/2175) - Remove the `creator` field from `m.room.create` events.
* [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) - Update the redaction rules.
* [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403) - Add "knock" feature.


Though other MSCs are capable of being included in this version, they do not have sufficient implementation to be
considered stable enough for v6 rooms. A future room version may still include them.

Room version 7 upon being added to the specification shall be considered stable. No other room versions are affected
by this MSC.