MSC2674: Event Relationships #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
added
kind:core
tulir
reviewed
Jul 7, 2020
Sorunome
reviewed
Jul 8, 2020
joepie91
reviewed
Jul 24, 2020
joepie91
reviewed
Jul 26, 2020
richvdh
reviewed
Jul 28, 2020
deepbluev7
reviewed
Oct 23, 2020
deepbluev7
reviewed
Apr 30, 2021
kevincox
reviewed
May 3, 2021
turt2live
added
the
needs-implementation
Co-authored-by: Richard van der Hoff <[email protected]>
This reverts commit e027133.
richvdh
reviewed
Nov 23, 2021
Co-authored-by: Richard van der Hoff <[email protected]>
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
turt2live
added a commit
that referenced
this pull request
Nov 23, 2021
* initial version of event relationship MSC * fix MSC numbers * clarifications * mention multiple relations per event might be useful, but postpone for a future MSC * mention MSC 3051 for proposed multiple relations * remove send_relation endpoint * move e2ee section under sending relations * mention limitation of leaving server-side aggregations out for now * remove mentions of m.reference, we'll sort that out in another MSC * whitespace * argument why m.relates_to should be preserved by redactions more general but still give example of redacted edits * deal with this in the comments * clarify the conditions to meet for a relation * mention specifically that this does not replace replies (yet) * clarify how general rel_types should be * clarify that gaps may cause clients to be unaware of some relations * Update proposals/2674-event-relationships.md Co-authored-by: DeepBlueV7.X <[email protected]> * Update proposals/2674-event-relationships.md Co-authored-by: DeepBlueV7.X <[email protected]> * make wording clearer and move to bottom of section * remove this as references are not defined here anymore * clearer wording * move edge cases to other relevant mscs * clarify that a goal of sticking to this format is backwards compat. * mention MSC 3267, to which m.reference has been extracted * Update proposals/2674-event-relationships.md Co-authored-by: Hubert Chathi <[email protected]> * Update proposals/2674-event-relationships.md Co-authored-by: Hubert Chathi <[email protected]> * Update proposals/2674-event-relationships.md Co-authored-by: Matthew Hodgson <[email protected]> * Update proposals/2674-event-relationships.md Co-authored-by: Matthew Hodgson <[email protected]> * Update proposals/2674-event-relationships.md Co-authored-by: Travis Ralston <[email protected]> * wrap lines * better wording * this is singular, really * add example of event shape * specify how invalid relations should be treated by the redaction algorithm * fix typo * split up redactions changes in separate MSC * also add new msc to introduction * reword why not adopt m.in_reply_to * remove guidelines how to pick rel_type * mention that the target event must exist in the same room * spell out the conscious (subject, object, verb) triple idea. * Spelling Co-authored-by: Richard van der Hoff <[email protected]> * remove paragraph saying what server should accept * Revert "remove paragraph saying what server should accept" This reverts commit e027133. * further specify that a server should reject invalid relations through the cs api * linebreak Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Bruno Windels <[email protected]> Co-authored-by: DeepBlueV7.X <[email protected]> Co-authored-by: Matthew Hodgson <[email protected]> Co-authored-by: Travis Ralston <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
turt2live
added
the
blocked
turt2live
removed
the
blocked
4 tasks
|
Spec PR: matrix-org/matrix-spec#1062 |
turt2live
added
spec-pr-in-review
turt2live
added
merged
|
Merged 🎉 |
66 tasks
This was referenced Jun 14, 2022
16 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Replaces #1849 along with #2675, #2676, and #2677
New FCP: #2674 (comment)