-
Notifications
You must be signed in to change notification settings - Fork 411
MSC2414: Make reason and score parameters optional for reporting content #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6005c16
Merge pull request #1 from matrix-org/master
iinuwa 692d039
Merge branch 'master' of github.com:iinuwa/matrix-doc
iinuwa 72bc0e0
Add proposal to make reason option on content reporting
iinuwa 2563711
Rename proposal with proper ID.
iinuwa bbad4c4
Add backwards-compatibility notes.
iinuwa 9be28c5
Add proposal to remove score; reorganize
iinuwa 07dbdab
Fix typos
iinuwa 51b278e
Mention the endpoint
turt2live 02512f0
Use endpoint instead of API
iinuwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# MSC2414: Make `reason` optional for reporting content | ||
|
||
Currently, the spec says that the `reason` parameter on the content reporting | ||
endpoint is required, but also says that the string "may be blank." This | ||
seems to be a contradiction. | ||
|
||
This MSC proposes that the `required` flag for this parameter be removed, as | ||
well as the "may be blank" clause in the description. | ||
|
||
Note that the kicking and banning endpoints already have optional `reason` | ||
parameters. The other endpoints mentioned in #2367 will likely also add | ||
iinuwa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
optional `reason` parameters, so it seems that it would be more more consistent | ||
with the rest of the spec to make this optional as well. | ||
uhoreg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.