Spec client-server IS unbind API #2282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/spec/is-unbind
branch
from
99089c6 to
185c564
Compare
turt2live
added
the
blocked
This was referenced Sep 4, 2019
|
matrix-org/synapse#5980 shows that this spec appears to be the correct way to do things. |
turt2live
removed
the
blocked
dbkr
reviewed
Sep 6, 2019
| summary: Removes a user's third party identifier from an identity server. | ||
| description: |- | ||
| Removes a user's third party identifier from the provided identity server. | ||
| This should not cause an unbind from the homeserver (as ``/3pid/delete`` |
There was a problem hiding this comment.
An 'unbind from the homeserver' isn't really a defined thing: 'binding' is the 3pid -> mxid mapping on the IS. I would just say maybe, "Removes a user's third party identifier from the provided identity server without removing it from the homeserver[...]".
dbkr
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 5 of many, as shown by #2253
Based on #2255 - the actual diff is here.See 'docs' status check for what this looks like in the spec.Specs part of MSC2140.
Note: this modifies the endpoint in MSC2140 to be more in line with the remainder of the proposal.