-
Notifications
You must be signed in to change notification settings - Fork 334
feat(sdk): Use state_after
in sync v2
#5488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is supposed to be an improvement over `state`, since it allows the server to send updates to the state that might not be reflected in the timeline. This is also the same behavior as in Simplified Sliding Sync. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
state_after
in sync v2
Signed-off-by: Kévin Commaille <[email protected]>
CodSpeed Performance ReportMerging #5488 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5488 +/- ##
==========================================
+ Coverage 88.93% 88.94% +0.01%
==========================================
Files 335 335
Lines 93274 93262 -12
Branches 93274 93262 -12
==========================================
+ Hits 82949 82956 +7
+ Misses 6462 6444 -18
+ Partials 3863 3862 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a couple of questions and suggestions.
Signed-off-by: Kévin Commaille <[email protected]>
It is supposed to be an improvement over
state
, since it allows theserver to send updates to the state that might not be reflected in the
timeline.
This is also the same behavior as in Simplified Sliding Sync.
This is MSC4222 that was accepted and is about to get merged in the spec.