Skip to content

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Aug 5, 2025

It is supposed to be an improvement over state, since it allows the
server to send updates to the state that might not be reflected in the
timeline.

This is also the same behavior as in Simplified Sliding Sync.

This is MSC4222 that was accepted and is about to get merged in the spec.

zecakeh added 2 commits August 5, 2025 19:32
It is supposed to be an improvement over `state`, since it allows the
server to send updates to the state that might not be reflected in the
timeline.

This is also the same behavior as in Simplified Sliding Sync.

Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner August 5, 2025 17:36
@zecakeh zecakeh requested review from andybalaam and removed request for a team August 5, 2025 17:36
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh changed the title feat(sdk): Use state_after in sync v2 feat(sdk): Use state_after in sync v2 Aug 5, 2025
Signed-off-by: Kévin Commaille <[email protected]>
Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed Performance Report

Merging #5488 will not alter performance

Comparing zecakeh:state-after (329151c) with main (787861e)

Summary

✅ 31 untouched benchmarks

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.94%. Comparing base (787861e) to head (329151c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...x-sdk-base/src/response_processors/room/sync_v2.rs 84.37% 3 Missing and 2 partials ⚠️
crates/matrix-sdk/src/widget/matrix.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5488      +/-   ##
==========================================
+ Coverage   88.93%   88.94%   +0.01%     
==========================================
  Files         335      335              
  Lines       93274    93262      -12     
  Branches    93274    93262      -12     
==========================================
+ Hits        82949    82956       +7     
+ Misses       6462     6444      -18     
+ Partials     3863     3862       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple of questions and suggestions.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from andybalaam August 6, 2025 10:09
@andybalaam andybalaam merged commit 056e90d into matrix-org:main Aug 6, 2025
51 checks passed
@zecakeh zecakeh deleted the state-after branch August 6, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants