Skip to content

Conversation

jmartinesp
Copy link
Contributor

This works around the issue with removed avatars not being explicitly flagged by sliding sync until element-hq/synapse#18598 is fixed.

This is a workaround for #5285.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner June 26, 2025 11:52
@jmartinesp jmartinesp requested review from stefanceriu and removed request for a team June 26, 2025 11:52
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smell incoming test failures, but LGTM once they're addressed!

@bnjbvr bnjbvr removed the request for review from stefanceriu June 26, 2025 11:55
@jmartinesp
Copy link
Contributor Author

I smell incoming test failures, but LGTM once they're addressed!

Agh, I forgot to run nextest. Let's see how many need to be fixed 🤞 .

@jmartinesp jmartinesp force-pushed the fix/sliding-sync-handles-removed-avatars branch from 867f727 to 060592c Compare June 26, 2025 11:58
This works around the issue with removed avatars not being explicitly flagged by sliding sync until element-hq/synapse#18598 is fixed
@jmartinesp jmartinesp force-pushed the fix/sliding-sync-handles-removed-avatars branch from 060592c to f7b1480 Compare June 26, 2025 12:02
@jmartinesp jmartinesp enabled auto-merge (rebase) June 26, 2025 12:02
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (836c643) to head (f7b1480).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5293      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         334      334              
  Lines      105155   105149       -6     
  Branches   105155   105149       -6     
==========================================
- Hits        94847    94840       -7     
  Misses       6245     6245              
- Partials     4063     4064       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 1de5161 into main Jun 26, 2025
44 checks passed
@jmartinesp jmartinesp deleted the fix/sliding-sync-handles-removed-avatars branch June 26, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants