Skip to content

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented May 14, 2025

No description provided.

@zecakeh zecakeh requested a review from a team as a code owner May 14, 2025 09:30
@zecakeh zecakeh requested review from Hywan and removed request for a team May 14, 2025 09:30
@zecakeh zecakeh force-pushed the stable-marked-unread branch from 1dac331 to 91c05c7 Compare May 14, 2025 09:47
zecakeh added 2 commits May 14, 2025 16:09
…prefix after seeing one with stable prefix

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh force-pushed the stable-marked-unread branch from beed15a to 1ea6410 Compare May 14, 2025 14:09
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (36667c1) to head (1ea6410).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5034   +/-   ##
=======================================
  Coverage   85.83%   85.84%           
=======================================
  Files         324      324           
  Lines       35842    35845    +3     
=======================================
+ Hits        30766    30771    +5     
+ Misses       5076     5074    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm requesting a tiny change, just to clarify the documentation of AccountDataSource. Other than that, I think we are good. Thanks for working on this!

Comment on lines +597 to +600
/// The source is account data with the stable prefix.
Stable,

/// The source is account data with the unstable prefix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to improve the doc by saying that the stable prefix is m. and the unstable prefix is com.famedly. I think it would clarify things greatly. Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this type vague on purpose to be able to reuse it eventually in the future since I doubt this is going to be the only case of room account data that we will need to migrate. Although the stable prefix should always be m., the unstable prefix will vary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then.

@Hywan Hywan merged commit 4847a31 into matrix-org:main May 16, 2025
43 checks passed
@zecakeh zecakeh deleted the stable-marked-unread branch May 16, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants