-
Notifications
You must be signed in to change notification settings - Fork 335
feat(sdk): Send stable m.marked_unread
room account data
#5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dac331
to
91c05c7
Compare
Signed-off-by: Kévin Commaille <[email protected]>
…prefix after seeing one with stable prefix Signed-off-by: Kévin Commaille <[email protected]>
beed15a
to
1ea6410
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5034 +/- ##
=======================================
Coverage 85.83% 85.84%
=======================================
Files 324 324
Lines 35842 35845 +3
=======================================
+ Hits 30766 30771 +5
+ Misses 5076 5074 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm requesting a tiny change, just to clarify the documentation of AccountDataSource
. Other than that, I think we are good. Thanks for working on this!
/// The source is account data with the stable prefix. | ||
Stable, | ||
|
||
/// The source is account data with the unstable prefix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to improve the doc by saying that the stable prefix is m.
and the unstable prefix is com.famedly
. I think it would clarify things greatly. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this type vague on purpose to be able to reuse it eventually in the future since I doubt this is going to be the only case of room account data that we will need to migrate. Although the stable prefix should always be m.
, the unstable prefix will vary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then.
No description provided.