refactor!(sdk): Set thumbnail in AttachmentConfig with builder method instead of constructor
#4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od instead of constructor
`Attachment::with_thumbnail()` is replaced by `AttachmentConfig::new().thumbnail()`.
Simplifies the use of `AttachmentConfig`, by avoiding code like:
```rust
let config = if let Some(thumbnail) = thumbnail {
AttachmentConfig::with_thumbnail(thumbnail)
} else {
AttachmentConfig::new()
};
```
Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
- Coverage 85.06% 85.05% -0.01%
==========================================
Files 283 283
Lines 31748 31749 +1
==========================================
- Hits 27005 27003 -2
- Misses 4743 4746 +3 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Dec 22, 2024
|
Oh the project is not using git-cliff anymore? Sure, I'll do that. |
Signed-off-by: Kévin Commaille <[email protected]>
Yeah, after a brief adventure we're back to manual changelogs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttachmentConfig::with_thumbnail()is replaced byAttachmentConfig::new().thumbnail().Simplifies the use of
AttachmentConfig, by avoiding code like: