feat!(timeline): Allow to send attachments from bytes

[zecakeh]

Sometimes we can get the bytes directly, e.g. in Fractal we can get an image from the clipboard. It avoids to have to write the data to a temporary file only to have the data loaded back in memory by the SDK right after.

The first commit to accept any type that implements Into<String> for the filename is grouped here because it simplifies slightly the second commit.

Note that we could also use AttachmentSource in the other send_attachment APIs, on Room and RoomSendQueue, for consistency.

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (1480fad) to head (eef5bb3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-ui/src/timeline/futures.rs	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4451      +/-   ##
==========================================
- Coverage   85.06%   85.05%   -0.01%     
==========================================
  Files         283      283              
  Lines       31748    31766      +18     
==========================================
+ Hits        27005    27019      +14     
- Misses       4743     4747       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zecakeh]

Added changelog entries in the commits.

[bnjbvr]

Makes sense, thanks!

[bnjbvr]

Once the conflict with CHANGELOG.md is fixed, I'm happy to land this.

[zecakeh]

I merged main into this branch to solve the conflict. Maybe you would have preferred a rebase to keep the history clean?

[bnjbvr]

I merged main into this branch to solve the conflict. Maybe you would have preferred a rebase to keep the history clean?

Thanks. It's rather up to you:

• I don't tend to merge PRs which contain merge commits as is, instead I'll squash-merge them.
• but if there's only clean atomic commits, I usually rebase-and-merge

So unless you have a strong preference for rebase-and-merge here (in which case, yes, please keep a clean history), I'll squash-merge later 👍

[zecakeh]

It's fine, you can merge as is 🙂 .