feat(crypto-nodejs): OlmMachine.initialize takes a new optional store type
#1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-crypto-nodejs-sqlite
branch
2 times, most recently
from
78b4c80 to
d172d8a
Compare
Hywan
commented
Feb 16, 2023
Hywan
force-pushed
the
feat-crypto-nodejs-sqlite
branch
from
d172d8a to
b8d2370
Compare
…re type. This patch allows an `OlmMachine` to use a different store than Sled, like SQLite. A new enum is introduced: `StoreType` which 2 variants: `Sled` (the default), and `Sqlite`. The `OlmMachine.initialize` constructor now takes a new optional `store_type: Option<StoreType>` argument. If no value is passed, the default `StoreType` variant will be used (as mentioned: `StoreType.Sled`). The code has been rewritten a little bit to make the type system happy without introducing too much type indirections. This patch finally adds a parameterized tests that exhaustively test: no store type, `Sled` and `Sqlite`.
Hywan
force-pushed
the
feat-crypto-nodejs-sqlite
branch
from
b8d2370 to
d600af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows an
OlmMachineto use a different store than Sled, like SQLite.A new enum is introduced:
StoreTypewith 2 variants:Sled(the default), andSqlite.The
OlmMachine.initializeconstructor now takes a new optionalstore_type: Option<StoreType>argument. If no value is passed, the defaultStoreTypevariant will be used (as mentioned:StoreType.Sled).The code has been rewritten a little bit to make the type system happy without introducing too much type indirections.
This patch finally adds a parameterized test that exhaustively tests: no store type,
SledandSqlite.