Skip to content

We currently log the access token in multiple places #1110

@jplatte

Description

@jplatte

We really shouldn't. Example from the matrix room, actual token replaced by X:

2022-10-14T20:51:05.184910Z TRACE sync_with_callback{sync_settings=SyncSettings { timeout: 30s, full_state: false }}:sync_with_result_callback{sync_settings=SyncSettings { timeout: 30s, full_state: false }}:sync_once{sync_settings=SyncSettings { timeout: 30s, token: "X", full_state: false }}:handle_sync_response:send_inner{request=Request { user_id: "@twig-bot:gnome.org" } config=None homeserver=None}:send{config=None homeserver="https://gnome.modular.im/" access_token=Some("X") user_id=Some("@twig-bot:gnome.org") server_versions=[V1_0, V1_1, V1_2] request_type="ruma_client_api::profile::get_display_name::v3::Request"}: matrix_sdk::http_client: Sending request

Metadata

Metadata

Assignees

Labels

help wantedInterested in working on the project? These are great additions we'd like to have!

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions