Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 18, 2022

Part of element-hq/element-web#23282

  • Now behaves like live location sharing (only disable sending them, not display)
  • Reduces complexity of MessageEvent

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 18, 2022
@weeman1337 weeman1337 requested a review from a team as a code owner October 18, 2022 09:22
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weeman1337 weeman1337 enabled auto-merge (squash) October 18, 2022 09:48
@t3chguy
Copy link
Member

t3chguy commented Oct 18, 2022

This is effectively a partial de-labsing and will need product sign-off

@t3chguy t3chguy requested a review from a team October 18, 2022 10:31
@weeman1337 weeman1337 disabled auto-merge October 18, 2022 10:31
@giomfo
Copy link
Member

giomfo commented Oct 19, 2022

This is effectively a partial de-labsing and will need product sign-off

@daniellekirkwood Hi, we suggest here displaying the received voice broadcast in the room timeline (and let the user listen to them) even if the voice broadcast Labs flag is disabled.
We are doing here the same as location sharing feature.
The labs flag is mainly used to prevent voice broadcast from sending which is under development.
Can you please approve this partial de-labsing?

@daniellekirkwood
Copy link

I have played with the feature in Labs on develop.element.io and agree that removing the tile and showing an empty message is less than ideal. I agree with the idea to copy location sharing and preserving the message as it was sent.

I have other reservations/defects on the feature but I will raise those in an alternative channel as they're not relevant for this question (like alignment, bubbles view, missing play buttons, and avatar sizes)

thanks!

@weeman1337 weeman1337 merged commit 84f2974 into develop Oct 19, 2022
@weeman1337 weeman1337 deleted the weeman1337/always-show-voice-broadcast branch October 19, 2022 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants