This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Conform more code to strictNullChecks (#10444
#10444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
t3chguy
changed the title
strictNullChecksstrictNullChecks (#10444
| await inviter.invite([member.userId]).then(() => { | ||
| if (inviter.getCompletionState(member.userId) !== "invited") { | ||
| throw new Error(inviter.getErrorText(member.userId)); | ||
| throw new Error(inviter.getErrorText(member.userId) ?? undefined); |
There was a problem hiding this comment.
new Error(undefined) isn't very useful.
In #10440, I've updated this to fallback to a better error message,
Suggested change
| throw new Error(inviter.getErrorText(member.userId) ?? undefined); | |
| throw new Error( | |
| inviter.getErrorText(member.userId) || | |
| `User (${member.userId}) did not end up as invited but no error was given from the inviter utility`, | |
| ); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21967
This change is marked as an internal change (Task), so will not be included in the changelog.