Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 14, 2023

Enable more jsx-a11y rules

  • "jsx-a11y/alt-text"
  • "jsx-a11y/label-has-associated-control"

UrlPreviewSettings [no visual change]
Removed unnecessary <label> wrappers (SettingsFlag adds a label internally)
Before:
Screenshot 2023-03-14 at 16 05 53
Screenshot 2023-03-14 at 16 05 28

After:
Screenshot 2023-03-14 at 16 01 58
Screenshot 2023-03-14 at 16 01 05

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 14, 2023
@kerryarchibald kerryarchibald changed the title Enable "jsx-a11y/alt-text" lint rule Enable "jsx-a11y/alt-text" and "jsx-a11y/label-has-associated-control" lint rules Mar 14, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review March 14, 2023 04:42
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 14, 2023 04:42
@kerryarchibald kerryarchibald enabled auto-merge (squash) March 14, 2023 21:04
@kerryarchibald kerryarchibald merged commit 209b652 into develop Mar 14, 2023
@kerryarchibald kerryarchibald deleted the kerry/a11y-img-alt branch March 14, 2023 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants