helm: Add support for mounting config from secret #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemrm
force-pushed
the
support-secrets
branch
from
80c39d1 to
09fc5b8
Compare
This change allows for config files to be sourced from a secret rather than a config map as these configs may have sensitive data. In addition to being able to source the config from a secret, the `extraContainerVolumeMounts` option was added which allows for mounting additional volumes defined in `extraContainerVolumes`, such mounting a passkey file secret. This also solves the same issue in a slightly different way from pr matrix-org#962 Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
support-secrets
branch
from
09fc5b8 to
2087651
Compare
|
@Half-Shot would you mind taking a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for config files to be sourced from a secret rather than a config map as these configs may have sensitive data.
In addition to being able to source the config from a secret, the
extraContainerVolumeMountsoption was added which allows for mounting additional volumes defined inextraContainerVolumes, such as mounting a passkey file secret.This also solves the same issue in a slightly different way from pr #962