Remove option to disable authentication of the 3pid endpoints #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/remove-checkToken
branch
from
785efbd to
e5e3bff
Compare
AndrewFerr
reviewed
May 25, 2022
AndrewFerr
approved these changes
May 25, 2022
|
Every CI failure is triggered by the same issue in |
Ah, but I had failed to update that file after changing the signature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
As of matrix-org/synapse#12746, Synapse now correctly sends us an access token when handling third party requests. There is no longer any need leave these endpoints unauthenticated.