Skip to content

Conversation

S7evinK
Copy link
Collaborator

@S7evinK S7evinK commented Jan 16, 2024

Knocking is not allowed in restricted rooms.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19c0a71) 59.80% compared to head (fbff586) 60.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   59.80%   60.03%   +0.23%     
==========================================
  Files          51       51              
  Lines        7137     7134       -3     
==========================================
+ Hits         4268     4283      +15     
+ Misses       2477     2458      -19     
- Partials      392      393       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems really broken that we allow invite->knock transitions... Invites are more important than knocks as you can then transition to join from it, but you can't with knock.

The only time I guess it's useful is to revoke an invite of a knocked user, but I would have probably advocated for invite->leave and then make the knocker knock again, but oh well.

Codewise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants