Allow using -p no:legacypath with pytest >= 7
#213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-p no:legacypath` option for `pytest` prevents using legacy `py.path` and forces using `pathlib` from the Python standard library instead. 07e12f4 (Remove usage of `py.path` with `pytest` 7) attempted to remove all uses of `py.path` with `pytest` >= 7 so that downstream packages could use that option, (at least with recent enough `pytest`). That commit introduced using `getattr()` to access the `path` attribute of `_pytest.nodes.Node` instances and falling back to the `fspath` attribute if `path` does not exist (which happens with `pytest` < 7). However, evaluating the `default` for `getattr()` then guarantees that `fspath` is accessed, which is incompatible with `-p no:legacypath`. The simplest way of avoiding accessing `fspath` is to use explicitly version-dependent code.
Merged
ConorMacBride
approved these changes
Nov 22, 2023
Member
ConorMacBride
left a comment
ConorMacBride
left a comment
There was a problem hiding this comment.
Good catch! Another way would be to have None as the default path attribute value and put the call to fspath after an or, but I think I prefer the explicit version check. It makes it easier to keep track of code only needed for older versions. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-p no:legacypathoption forpytestprevents using legacypy.pathand forces usingpathlibfrom the Python standard library instead. 07e12f4 attempted to remove all uses ofpy.pathwithpytest>= 7 so that downstream packages could use that option, (at least with recent enoughpytest). That commit introduced usinggetattr()to access thepathattribute of_pytest.nodes.Nodeinstances and falling back to thefspathattribute ifpathdoes not exist (which happens withpytest< 7). However, evaluating thedefaultforgetattr()then guarantees thatfspathis accessed, which is incompatible with-p no:legacypath. The simplest way of avoiding accessingfspathis to use explicitly version-dependent code.