Skip to content

Conversation

@proux01
Copy link
Contributor

@proux01 proux01 commented Feb 11, 2025

No description provided.

@proux01 proux01 marked this pull request as ready for review February 11, 2025 12:04
@proux01
Copy link
Contributor Author

proux01 commented Feb 11, 2025

@CohenCyril @gares CI "green" but this is dropping support for 8.18, 819 and 8.20. Fine to me since we got a recent release supporting all of those and 9.0.0 should come soon but we might want to wait before merging.

@CohenCyril
Copy link
Member

@CohenCyril @gares CI "green" but this is dropping support for 8.18, 819 and 8.20. Fine to me since we got a recent release supporting all of those and 9.0.0 should come soon but we might want to wait before merging.

I'm in favor of waiting a bit.

@proux01 proux01 force-pushed the no-stdlib branch 2 times, most recently from b65130f to 56437fa Compare February 12, 2025 10:57
@proux01
Copy link
Contributor Author

proux01 commented Feb 12, 2025

Apparently it wasn't that hard to keep compatibility with 8.18-8.20, so let's merge.

@proux01 proux01 merged commit 4020b53 into math-comp:master Feb 12, 2025
156 checks passed
@proux01 proux01 deleted the no-stdlib branch February 12, 2025 12:52
@@ -1,5 +1,5 @@
From HB Require Import structures.
From Coq Require Import ssreflect ZArith.
From Corelib Require Import ssreflect BinNums IntDef.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proux01 this header is not rewritten when I run make with coq 8.20, is it expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, my only objective was to keep the main build on Coq 8.20, maybe not all examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll make a patch to make examples work too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that the CI was not testing the examples :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants